8000 Use of wrong flags makes rio to get stuck without failing · Issue #707 · rancher/rio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Use of wrong flags makes rio to get stuck without failing #707

Closed
izaac opened this issue Nov 7, 2019 · 1 comment
Closed

Use of wrong flags makes rio to get stuck without failing #707

izaac opened this issue Nov 7, 2019 · 1 comment
Assignees
@izaac @cbron
Labels
bug Something isn't working
Milestone
v0.7.0

Comments

@izaac
Copy link
izaac commented Nov 7, 2019 •
edited
Loading

Describe the bug
rio is stuck if I use a wrong flag during rio run for example.

To Reproduce
Steps to reproduce the behavior:

  1. install rio
  2. do a rio run --helop wrongly setting the flag with a typo
  3. rio is stuck there without failing

Shell I'm using is zsh 5.7.1 (x86_64-apple-darwin19.0) Mac OS Catalina 10.15.1

Expected behavior

Make rio fail quick if there are wrong flags set during CLI invocation.

Kubernetes version & type (GKE, on-prem): kubectl version

Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.6", GitCommit:"96fac5cd13a5dc064f7d9f4f23030a6aeface6cc", GitTreeState:"clean", BuildDate:"2019-08-19T11:13:49Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2-k3s.1", GitCommit:"b8b17ba55f20e590df507fce333dfee13ab438c6", GitTreeState:"clean", BuildDate:"2019-10-16T05:17Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}

Type:
Rio version: rio info

rio version v0.6.0-alpha.3 (98e09134)

Additional context
rio systemlogs
output:

Nothing relevant in systemlogs
@izaac izaac changed the title Use of wrong flags makes rio to get stuck without failing Use of wrong flags makes rio to get stuck without failing [0.6.0-alpha.3] Nov 7, 2019
@davidnuzik davidnuzik added this to the v1.0 - Backlog milestone Nov 7, 2019
@davidnuzik davidnuzik added the enhancement New enhancement to an existing feature or request to enhance a feature label Nov 7, 2019
@izaac izaac changed the title Use of wrong flags makes rio to get stuck without failing [0.6.0-alpha.3] Use of wrong flags makes rio to get stuck without failing Nov 14, 2019
@daniel-sullivan daniel-sullivan mentioned this issue Nov 18, 2019
Closed
@cbron cbron mentioned this issue Nov 22, 2019
Merged
@cbron cbron assigned cbron and unassigned StrongMonkey Nov 22, 2019
@cbron cbron modified the milestones: v1.0 - Backlog, v0.6.x Nov 22, 2019
@cbron cbron added bug Something isn't working [zube]: Peer Review and removed enhancement New enhancement to an existing feature or request to enhance a feature [zube]: Peer Review labels Nov 22, 2019
@rancher-max
Copy link
Member

Working now in master (0.6.x).

Now the behavior is that it will give the default --help result, followed by a FATAL error, such as: FATA[0000] flag provided but not defined: -helop

@davidnuzik davidnuzik modified the milestones: v0.6.x, v0.7.0 Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@izaac izaac

@cbron cbron

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
5 participants
@izaac @cbron @StrongMonkey @davidnuzik @rancher-max
0