8000 snapshot_accept() links don't work correctly when path is not "." · Issue #2089 · r-lib/testthat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
snapshot_accept() links don't work correctly when path is not "." #2089
Open
@moodymudskipper

Description

@moodymudskipper

The possibility to run tests out of the working folder is very useful for me working on a repo containing several internal packages for a client.

However the feature is partially broken due to the snapshot accept suggestions not finding snapshot to update whenever clicked, because they only look in the test dir relevant to the working directory.

The snapshot_accept() suggestions take tests by names, if they took the paths instead of(ot took paths whenever the test function has a path different from".") I believe this would solve the issue.

Thanks for the great work.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0