8000 False positive inside generic · Issue #8 · r-lib/ellipsis · GitHub

More Web Proxy on the site http://driver.im/

False positive inside generic #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

hadley opened this issue Feb 18, 2019 · 1 comment

8000

Member

hadley commented

as_factor <- function(x, ...) {
  ellipsis::check_dots_used()
  UseMethod("as_factor")
}

as_factor.character <- function(x, ..., y)  {
  force(y)
  x
}
as_factor("x", y = 1)
#> Warning: Some components of ... were not used: y
#> [1] "x"

^{Created on 2019-02-18 by the reprex package (v0.2.1.9000)}

hadley mentioned this issue

as_factor leads to warnings with ellipsis::check_dots_used tidyverse/haven#432

Closed

Member Author

hadley commented

Doesn't seem restricted to generics:

f <- function(x, ...) {
  ellipsis::check_dots_used()
  g(x, ...)
}

g <- function(x, ..., y)  {
  force(y)
  x
}
f("x", y = 1)
#> Warning: Some components of ... were not used: y
#> [1] "x"

^{Created on 2019-02-18 by the reprex package (v0.2.1.9000)}

hadley closed this as completed in

8fa6bcb

kevinykuo mentioned this issue

Deprecations for 1.0 sparklyr/sparklyr#1914

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

0