Description
Describe the bug
Thanks to @akatan999 for reporting that the SSbiologytables() function was crashing.
This function was added by @chantelwetzel-noaa in 2018 in response to a request by Jim Hastie for additional tables of selectivity by fleet and biology at age in the US West Coast groundfish assessment reports and was designed to work for our typical model configurations.
However, the function does not currently work correctly for a variety of common model configurations, including single-sex models and models without length-based selectivity. Also, I don't see any reference to this function being used in any code on github, including in recent US West Coast groundfish assessments.
Here are a few options going forward
- deprecate the function and let users write their own model-specific or region-specific code in different packages to create whatever tables they need (for NOAA folks, this could include adding these tables to the https://github.com/nmfs-ost/satf package if the tables are deemed necessary for our reports in the future)
- fix the function to work for all model configurations
- modify the function to exit with a warning if you apply it to a configuration which is not supported.
I like option 1 best but am open to option 2. Option 3 doesn't seem helpful.
@chantelwetzel-noaa, if we choose option 2 I'm happy to do the work, but your input on whether it's a good idea would be appreciated.
To Reproduce
Run SSbiologytables() on a single-sex model or one with only age-based selectivity.
Expected behavior
Runs without crashing and writes tables of biology at age and selectivity at age and/or length.
Screenshots
No response
Which OS are you seeing the problem on?
No response
Which versions of r4ss and SS3 are you seeing the problem on?
No response
Additional Context
No response
Code of Conduct
- I agree to follow this project's Code of Conduct