diff --git a/src/platform/Darwin/DnssdContexts.cpp b/src/platform/Darwin/DnssdContexts.cpp index 46c7bb34fc4365..7dc5956845414f 100644 --- a/src/platform/Darwin/DnssdContexts.cpp +++ b/src/platform/Darwin/DnssdContexts.cpp @@ -492,10 +492,7 @@ ResolveContext::ResolveContext(DiscoverNodeDelegate * delegate, chip::Inet::IPAd ResolveContext::~ResolveContext() { - if (isSRPTimerRunning) - { - CancelSRPTimer(); - } + CancelSRPTimerIfRunning(); } void ResolveContext::DispatchFailure(const char * errorStr, CHIP_ERROR err) @@ -647,10 +644,14 @@ void ResolveContext::SRPTimerExpiredCallback(chip::System::Layer * systemLayer, sdCtx->Finalize(); } -void ResolveContext::CancelSRPTimer() +void ResolveContext::CancelSRPTimerIfRunning() { - DeviceLayer::SystemLayer().CancelTimer(SRPTimerExpiredCallback, static_cast(this)); - ChipLogProgress(Discovery, "SRP resolve timer for %s cancelled; resolve timed out", instanceName.c_str()); + if (isSRPTimerRunning) + { + DeviceLayer::SystemLayer().CancelTimer(SRPTimerExpiredCallback, static_cast(this)); + ChipLogProgress(Discovery, "SRP resolve timer for %s cancelled; resolve timed out", instanceName.c_str()); + isSRPTimerRunning = false; + } } CHIP_ERROR ResolveContext::OnNewAddress(const InterfaceKey & interfaceKey, const struct sockaddr * address) diff --git a/src/platform/Darwin/DnssdImpl.cpp b/src/platform/Darwin/DnssdImpl.cpp index a9dccf21ef47f5..4156c7a4bf0924 100644 --- a/src/platform/Darwin/DnssdImpl.cpp +++ b/src/platform/Darwin/DnssdImpl.cpp @@ -272,6 +272,13 @@ static void OnGetAddrInfo(DNSServiceRef sdRef, DNSServiceFlags flags, uint32_t i if (flags & kDNSServiceFlagsMoreComing) { + // If we now don't need to have a timer while we wait for SRP results, ensure that there is no such + // timer running. Otherwise the timer could fire before we get the rest of the results that flags + // say are coming, and trigger a finalize before we have all the data that is already available. + if (!sdCtx->shouldStartSRPTimerForResolve) + { + sdCtx->CancelSRPTimerIfRunning(); + } return; } diff --git a/src/platform/Darwin/DnssdImpl.h b/src/platform/Darwin/DnssdImpl.h index 3cf48db33545a5..42ae55fdd9d4c0 100644 --- a/src/platform/Darwin/DnssdImpl.h +++ b/src/platform/Darwin/DnssdImpl.h @@ -297,6 +297,12 @@ struct ResolveContext : public GenericContext */ static void SRPTimerExpiredCallback(chip::System::Layer * systemLayer, void * callbackContext); + /** + * @brief Cancels the timer that was started to wait for the resolution on the kSRPDot domain to happen. + * + */ + void CancelSRPTimerIfRunning(); + private: /** * Try reporting the results we got on the provided interface index. @@ -306,12 +312,6 @@ struct ResolveContext : public GenericContext bool TryReportingResultsForInterfaceIndex(uint32_t interfaceIndex, const std::string & hostname, bool isSRPResult); bool TryReportingResultsForInterfaceIndex(uint32_t interfaceIndex); - - /** - * @brief Cancels the timer that was started to wait for the resolution on the kSRPDot domain to happen. - * - */ - void CancelSRPTimer(); }; } // namespace Dnssd