8000 [BUG] Fix the encoding of MTRCommandPath, MTRAttributePath and MTREventPath · Issue #32856 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUG] Fix the encoding of MTRCommandPath, MTRAttributePath and MTREventPath #32856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
moe-mehrabi opened this issue Apr 4, 2024 · 0 comments · Fixed by #32862
Closed

[BUG] Fix the encoding of MTRCommandPath, MTRAttributePath and MTREventPath #32856

moe-mehrabi opened this issue Apr 4, 2024 · 0 comments · Fixed by #32862
Labels
bug Something isn't working darwin needs triage

Comments

@moe-mehrabi
Copy link

Reproduction steps

The NS(Secure)Coding is not properly implemented for MTR Path classes. There are two issues:

  1. MTRAttributePath doesnt call super for the encodeWithCoder which results in cluster path and endpoint path to not get encoded.
- (void)encodeWithCoder:(NSCoder *)coder
{
    [coder encodeObject:_attribute forKey:sAttributeKey];
}

MTRCommandPath and MTREventPath dont implement

- (nullable instancetype)initWithCoder:(NSCoder *)decoder

and

- (void)encodeWithCoder:(NSCoder *)coder

Bug prevalence

Always

GitHub hash of the SDK that was being used

96329ae

Platform

darwin

Platform Version(s)

No response

Anything else?

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working darwin needs triage
Projects
[Platform] Darwin
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Darwin] MTRAttributePath NSSecureCoding fix jtung-apple/connectedhomeip
1 participant
@moe-mehrabi
0