8000 GeneralCommissioningCluster.xml: Code and spec attributes not aligned · Issue #39784 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
GeneralCommissioningCluster.xml: Code and spec attributes not aligned #39784
Open
@OlivierGre

Description

@OlivierGre

There is possibly an issue in data_model/master/clusters/GeneralCommissioningCluster.xml: the code and specifications seem not aligned.

Spec on master currently contains:

  • attribute id "0x000A" "RecoveryIdentifier"
  • attribute id "0x000B" "NetworkRecoveryReason"
    (and we have a PR to add a new attribute with id 0x000C).

data_model/master/clusters/GeneralCommissioningCluster.xml contains:

  • attribute id "0x000A" "NFCConstrainedDataModel"
  • attribute id "0x000B" "RecoveryIdentifier"
  • attribute id " 513C 0x000C" "NetworkRecoveryReason"

The reason is that, some time ago, an attribute called NFCConstrainedDataModel was added to the spec (with attribute id="0x000A") it was finally removed from the spec. It seems that it was added a bit too early in the code. Shall we remove it and use the id 0x000A and 0x000B for RecoveryIdentifier and NetworkRecoveryReason? (to be aligned with the spec)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0