8000 Unify the "device type" structure between ember and codegen data model provider · Issue #35889 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Unify the "device type" structure between ember and codegen data model provider #35889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andy31415 opened this issue Oct 3, 2024 · 1 comment · Fixed by #37143
Closed

Unify the "device type" structure between ember and codegen data model provider #35889

andy31415 opened this issue Oct 3, 2024 · 1 comment · Fixed by #37143
Assignees
@andy31415
Labels
Interaction Model Work

Comments

@andy31415
Copy link
Contributor

#35861 introduces DataModel::DeviceTypeEntry which in practice is identical to EmberAfDeviceType.

Figure out a way to share this definition. Ember types are not to be exposed externally (codegen implementation should be the only ember aware code in the long run). DataModel types are global, however we have to consider if we really want to make ember depend on data provider interfaces.
@andy31415 andy31415 mentioned this issue Oct 3, 2024
Merged
@bzbarsky-apple
Copy link
Contributor

we have to consider if we really want to make ember depend on data provider interfaces

I think that would be absolutely fine.

@andy31415 andy31415 mentioned this issue Jan 17, 2025
Merged
@andy31415 andy31415 self-assigned this Jan 21, 2025
@andy31415 andy31415 moved this to In Progress in Cluster and example long term maintainability Jan 21, 2025
@andy31415 andy31415 mentioned this issue Jan 21, 2025
Merged
@andy31415 andy31415 moved this from In Progress to In review in Cluster and example long term maintainability Jan 21, 2025
@mergify mergify bot closed this as completed in #37143 Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andy31415 andy31415

Labels
Interaction Model Work
Projects
Cluster and example long term maintainability
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-use chip::app::DataModel::DeviceTypeEntry as EmberAfDeviceType andy31415/connectedhomeip
2 participants
@andy31415 @bzbarsky-apple
0