8000 service-area-server.cpp remove check for CurrentArea == NULL when executing skip command · Issue #34934 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

service-area-server.cpp remove check for CurrentArea == NULL when executing skip command #34934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnfierke opened this issue Aug 12, 2024 · 0 comments · Fixed by #35075
Closed

service-area-server.cpp remove check for CurrentArea == NULL when executing skip command #34934

johnfierke opened this issue Aug 12, 2024 · 0 comments · Fixed by #35075
Assignees
@hicklin

Comments

@johnfierke
Copy link
Contributor

This is no longer a cluster requirement, the check should not be in the common SDK code:

void Instance::HandleSkipCurrentAreaCmd change to void Instance::HandleSkipAreaCmd

Delete the following check:

// If the CurrentArea attribute is null, the status should be set to InvalidInMode.
// If the Status field is not set to Success, or InvalidAreaList, the StatusText field SHALL include a vendor defined error
// description.
if (mCurrentArea.IsNull())
{
    exitResponse(SkipAreaStatus::kInvalidInMode, "Current Area attribute is null"_span);
    return;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hicklin hicklin

Labels
None yet
Projects
[Device Type] Robot Vacuums
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SkipArea logic and removed the use of memcpy dysonltd/connectedhomeip
2 participants
@hicklin @johnfierke
0