8000 Remove the nullable quality of ServiceArea list attributes · Issue #34669 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove the nullable quality of ServiceArea list attributes #34669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hicklin opened this issue Jul 31, 2024 · 0 comments · Fixed by #34732
Closed

Remove the nullable quality of ServiceArea list attributes #34669

hicklin opened this issue Jul 31, 2024 · 0 comments · Fixed by #34732
Assignees
@hicklin

Comments

@hicklin
Copy link
Contributor
hicklin commented Jul 31, 2024

Implement the spec change in this PR that addressed this issue.

  • Remove the nullabel quality form the SupportedAreas, SupportedMaps, SelectedAreas and Progress attributes.
  • Remove the nullabel quality form the NewAreas argument in the SelectAreas command.
  • Instead of checking for null, check for empty.
@hicklin hicklin self-assigned this Jul 31, 2024
@bzbarsky-apple bzbarsky-apple changed the title Remove the nullabel quality of ServiceArea list attributes Remove the nullable quality of ServiceArea list attributes Jul 31, 2024
This was referenced Aug 2, 2024
Merged
Merged
@hicklin hicklin moved this from Todo to In Progress in [Device Type] Robot Vacuums Aug 2, 2024
@mergify mergify bot closed this as completed in #34732 Aug 6, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in [Device Type] Robot Vacuums Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hicklin hicklin

Labels
None yet
Projects
[Device Type] Robot Vacuums
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Service Area: Remove nullable qualities to match the latest spec dysonltd/connectedhomeip
1 participant
@hicklin
0