Issue-Label Bot is automatically applying the label bug 🐞 to this issue, with a confidence of 0.83. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

I'm also seeing this deprecation after the 4 comments are created (I'm thinking maybe after a rate limit error?)

Deprecation: [@octokit/request] error.code is deprecated, use error.status.
at HttpError.get (/app/node_modules/probot/node_modules/@octokit/request/lib/http-error.js:18:17)
at Object.Logger.stdSerializers.err (/app/node_modules/bunyan/lib/bunyan.js:1148:19)
at /app/node_modules/bunyan/lib/bunyan.js:873:50
at Array.forEach ()
at Logger._applySerializers (/app/node_modules/bunyan/lib/bunyan.js:865:35)
at mkRecord (/app/node_modules/bunyan/lib/bunyan.js:978:17)
at Logger.error (/app/node_modules/bunyan/lib/bunyan.js:1044:19)
at Application. (/app/node_modules/probot/lib/application.js:159:33)
at step (/app/node_modules/probot/lib/application.js:43:23)
at Object.throw (/app/node_modules/probot/lib/application.js:24:53)
at rejected (/app/node_modules/probot/lib/application.js:16:65) name: 'Deprecation'

Apparently this was not fixed by: #871

regarding the first deprecation, context.issue() needs to be update to set issue_number instead of number. The pull request should also bump the minimal required version of @octokit/rest. Would you like to try sending a pull request to get rid of the deprecation message?

@gr2m I took a look at the required changes; I don't know typescript so that is a hindrance for me. It seems the pull requests should also change from number to pull_number https://octokit.github.io/rest.js/#octokit-routes-pulls-create-comment
so we should have something like this in context.ts:

interface WebhookPayloadWithRepository {
  [key: string]: any
  repository?: PayloadRepository
  issue?: {
    [key: string]: any
    issue_number: number
    html_url?: string
    body?: string
  }
  pull_request?: {
    [key: string]: any
    pull_number: number
    html_url?: string
    body?: string
  }

Then we change the object key to the appropriate key in the method below. But I'm not sure what to do with the third term || payload:

  public issue<T> (object?: T) {
    const payload = this.payload
    return Object.assign({
      number: (payload.issue || payload.pull_request || payload).number
    }, this.repo(object))
  }

When payload does not have an issue key, or a pull_request key, what is it?

🚧 Fix in #926

Apparently this was not fixed by: #871

I second that. I'm seeing this in v9.2.9. I commented on a closed issue but maybe this is a better place?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Still an issue

It is still happening, I am not able to use my app which was working before.

This is just a deprecation warning, not an Error. It should not affect your app

Still happening on "probot": "^9.6.6"

It cannot be fixed without a breaking change, so we hold back until v10

🎉 This issue has been resolved in version 10.0.0-beta.9 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀