8000 Comparing LineageOS:lineage-22.2...pranaya-workspace:lineage-21 · LineageOS/android_tools_extract-utils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: LineageOS/android_tools_extract-utils
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: lineage-22.2
Choose a base ref
...
head repository: pranaya-workspace/android_tools_extract-utils
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: lineage-21
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 1 file changed
  • 2 contributors

Commits on Apr 9, 2024

  1. Revert "extract-utils: Disable elf checks by default" 

    This reverts commit 3b7da6c.
    @pranayadmn
    pranayadmn committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    3da8c88 View commit details
    Browse the repository at this point in the history

  2. Revert "extract-utils: Specify arch for binary targets" 

    This reverts commit 71a53af.
    @pranayadmn
    pranayadmn committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    0caac07 View commit details
    Browse the repository at this point in the history

  3. Revert "extract-utils: Support rfsa package targets on vendor" 

    This reverts commit 563d962.
    @pranayadmn
    pranayadmn committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    e8fb58f View commit details
    Browse the repository at this point in the history

  4. Revert "extract-utils: Enable elf checks on elf targets" 

    This reverts commit 94fac09.

Change-Id: I3f81079ac051e74d40b52555579ebc4250c48a42
    @pranayadmn
    pranayadmn committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    b1e8054 View commit details
    Browse the repository at this point in the history

  5. extract_utils: Add optionnal support for check_elf_files 

    * By default, extract_utils always disables ELF checks on prebuilt
  binaries / libraries that are installed as packages

* This commits add support for generating shared_libs list and enabling
  ELF checks by setting the `EU_ENABLE_BINARY_CHECKS` to "true". Shared
  libs list is generated using `patchelf (--print-needed)` and is
  checked by check_elf_files.py during build.

* check_elf_files makes sure SONAME matches installed library name,
  shared_libs matches DT_NEEDED and no undefined symbols are found.

* To help working with shared_libs list, modules can specify additionnal
  arguments: `ADDEP=libname`, `RMDEP=libname` and
  `REPLACEDEP=oldname:newname`

* Be aware that when checking shared_libs, check_elf_files look at the
  lib's SONAME, which doesn't always equals its SONAME. In such cases,
  you must use `REPLACEDEP=lib_package_name:lib_soname`

* To disable checks for a specific file, you can either use `NOCHECK`
  arg to disable `check_elf_files` but keep shared_libs generation,
  `NODEPS` to disable both `shared_libs` and `check_elf_files` and
  `NOSYMBOLS` to allow undefined symbols (while keeping other checks)

Signed-off-by: Woomymy <woomy@woomy.be>
Change-Id: I4a77780a1b648cdd178bc9614b631c0318895b52
    @Woomymy @pranayadmn
    Woomymy authored and pranayadmn committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    4e04fda View commit details
    Browse the repository at this point in the history

  6. extract_utils: Add support for adding imports in vendor soong_namespace 

    * Add a third argument to write_headers containing a comma-separated
  list of soong namespace that should be imported in vendor
  soong_namespae (Useful for shared_libs resolution when ELF checks are
  enabled)

Signed-off-by: Woomymy <woomy@woomy.be>
Change-Id: I6596e8014d1e30ee3d4d00371b137fe5d2c90932
    @Woomymy @pranayadmn
    Woomymy authored and pranayadmn committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    9123921 View commit details
    Browse the repository at this point in the history

  7. extract_utils: Add vndk_import helper to import older vndk libraries 

    * Add a small vndk_import helper that generates blueprint to import
  older libs as <libname>-v<vndk version>.

* This should be used after setup-makefiles call. params: `vndk_import "${ANDROID_ROOT}" "LIBNAME (eg: libcrypto)" "VERSION (eg: 32)" "BITNESS ("64", "32" or "both")" "DIRECTORY (eg: vndk-core, vndk-sp)"`

Signed-off-by: Woomymy <woomy@woomy.be>
Change-Id: Ic5dc6f02cb1d94c9614f9254a9dae4bcfeed809f
    @Woomymy @pranayadmn
    Woomymy authored and pranayadmn committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    96af9e8 View commit details
    Browse the repository at this point in the history

  8. extract_utils: Fix shared_libs entries that contain ".so" in their name 

    * Replacing .so with "" in the name of the libs breaks every library
  that has ".so" in its name (like android.hardware.soundtrigger), just
  remove everything after the last dot instead

Signed-off-by: Woomymy <woomy@woomy.be>
Change-Id: I212f55e0e69e8ec3ecc9dd5aa10c16259523af2b
    @Woomymy @pranayadmn
    Woomymy authored and pranayadmn committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    04d9bda View commit details
    Browse the repository at this point in the history

  9. extract_utils: Don't remove the "extension" if it makes the package n… 

    …ame empty

* Trying to remove the "file extension" on names such as `.hidden` will
  turn the package name into an empty string

Change-Id: Ia84345ad3836b640b65d981f8a186a1056cf1350
Signed-off-by: Woomymy <woomy@woomy.be>
    @Woomymy @pranayadmn
    Woomymy authored and pranayadmn committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    d1a67d1 View commit details
    Browse the repository at this point in the history

  10. extract_utils: Keep .xml extension for VINTF manifests 

    * Prevent conflicts if the VINTF manifest fragment has the same name
  than the service + .xml

Change-Id: Idabf4c41b8fec1d79d1cdbd8434ede9b1f853d20
Signed-off-by: Woomymy <woomy@woomy.be>
    @Woomymy @pranayadmn
    Woomymy authored and pranayadmn committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    c5f3391 View commit details
    Browse the repository at this point in the history
Loading
0