Allow user-defined function in origin option #60
Labels
Comments
|
i basically thought of 2 approaches: Callbacki kind of already implemented this, but it makes the underlying code quite complicated, because of the problems, that callbacks introduce. Exampleconst cors = microCors({
origin(origin, callback) {
asyncAction(data => {
if (data === 'foo') {
callback(undefined, true)
} else {
callback(undefined, false)
}
})
},
})
const router = micro(cors(() => ({})))Promisei think the callback idea is more fitting for express because express was not made for promises and all that new shiny async/await stuff. but since micro depends on async/await, why not use a promise approach for this case? i think it would be much easier to implement and use. Exampleconst cors = microCors({
async origin(origin) {
const data = await asyncAction(origin)
if (data === 'foo') {
return true
} else {
return false
}
},
})
const router = micro(cors(() => ({}))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@lucasfischer, could you sum up your research so far? like possible ways to approach, etc. Doesn’t need to be too specific, we’ll discuss pros and cons of the different approaches.
The text was updated successfully, but these errors were encountered: