[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-dropzone component #9154

Closed
jacogr opened this issue Mar 12, 2023 · 2 comments · Fixed by #9169
Closed

Upgrade react-dropzone component #9154

jacogr opened this issue Mar 12, 2023 · 2 comments · Fixed by #9169

Comments

@jacogr
Copy link
Member
jacogr commented Mar 12, 2023

The react-dropzone component is used in react-components/InputFile.tsx and is in need of an upgrade.

  1. Upgrade package to latest,
    "react-dropzone": "^11.7.1",
  2. Familiarize with the new useDropzone usage in https://react-dropzone.js.org/
  3. The actual usage is in react-components/InputFile.tsx, specifically here
    import Dropzone, { DropzoneRef } from 'react-dropzone';
  4. Instead of import Dropzone from 'react-dropzone' we want to use import { useDropzone } from 'react-dropzone'
  5. Test... best place is probably extrinsics -> system.setCode (if it works there, should do elsewhere)

Doing so will also (almost...) allow us to swap to removing the moduleResolution: "node" override we have in tsconfig.base.json (Some additional tweaks may be required after the above swap)

@jacogr
Copy link
Member Author
jacogr commented Mar 12, 2023

The same also needs to be done in the extension, i.e. once working here we should swap that out as well (and once-again should be tested)

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants