8000 Limit size of the description shown for episodes and podcasts · Issue #349 · podStation/podStation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Limit size of the description shown for episodes and podcasts #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dellagustin opened this issue Mar 15, 2023 · 3 comments
Open

Limit size of the description shown for episodes and podcasts #349

dellagustin opened this issue Mar 15, 2023 · 3 comments
Labels
enhancement good first issue

Comments

@dellagustin
Copy link
Contributor

Episodes and podcasts can have very long descriptions.
We should limit the size of these descriptions with a "show more button".
See for instance https://500songs.com/podcast/ (feed: https://500songs.com/feed/podcast).

image
@martinyis
Copy link

Hey, I would like to work on that!
A few clarifications
-where does this component located in the files?
-What max-size of text do you want me to set
If you can provide this info, assign it to me!

@dellagustin
Copy link
Contributor Author

Hi @martinyis , thank you for you interest in contributing.
I'll try to get you the info this weekend.

@dellagustin
Copy link
Contributor Author

So, we are still using the now ancient AngularJS, and that is likely to remain for some time, as migrating from that would take a lot of effort.
For local setup and testing you can refer to https://github.com/podStation/podStation#development.
If you are using VSCodes, some editor settings will come automatically, but if not, basically we use tabs, not spaces (team tabs here, following the teachings of https://lea.verou.me/2012/01/why-tabs-are-clearly-superior/).

Your works will be on the "frontend". We don't have a backend, but there is JS code that runs on a so called background page.

You will likely have to touch:

Regarding max size, I'm thinking something between 300 and 400 pixels.
Limiting the vertical size here should do it:

podStation/src/ui/ng/partials/episodeList.html

Line 48 in 4fc7de2

<div class="itemDescription" ng-bind-html="episode.description">

The challenge for me is how to detect it has been overflown to show a "show more" button somewhere.
I hope that helps, if you have questions, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dellagustin @martinyis
0