executor: support semi join #57658
executor: support semi join #57658
Conversation
|
/cc @windtalker |
pkg/executor/join/base_join_probe.go
Outdated
| @@ -747,7 +763,15 @@ func NewJoinProbe(ctx *HashJoinCtxV2, workID uint, joinType logicalop.JoinType, | |||
| return newOuterJoinProbe(base, !rightAsBuildSide, rightAsBuildSide) | |||
| case logicalop.RightOuterJoin: | |||
| return newOuterJoinProbe(base, rightAsBuildSide, rightAsBuildSide) | |||
| case logicalop.SemiJoin: | |||
| if len(base.rUsed) != 0 { | |||
| panic("len(base.rUsed) != 0") | |||
There was a problem hiding this comment.
| panic("len(base.rUsed) != 0") | |
| panic("len(base.rUsed) != 0 for semi join") |
pkg/executor/join/base_join_probe.go
Outdated
| case logicalop.LeftOuterSemiJoin: | ||
| if len(base.rUsed) != 0 { | ||
| panic("len(base.rUsed) != 0") |
There was a problem hiding this comment.
| panic("len(base.rUsed) != 0") | |
| panic("len(base.rUsed) != 0 for lefter outer semi join") |
| return | ||
| } | ||
|
|
||
| func (s *semiJoinProbe) generateResultChkForRightBuildNoOtherCondition(resultChk *chunk.Chunk) { |
There was a problem hiding this comment.
return if len(s.offsets) == 0?
There was a problem hiding this comment.
return if
len(s.offsets) == 0?
done
| candidateRow := tagHelper.toUnsafePointer(s.matchedRowsHeaders[s.currentProbeRow]) | ||
| if isKeyMatched(meta.keyMode, s.serializedKeys[s.currentProbeRow], candidateRow, meta) { | ||
| s.matchedRowsHeaders[s.currentProbeRow] = 0 | ||
| s.offsets = append(s.offsets, s.usedRows[s.currentProbeRow]) |
There was a problem hiding this comment.
update s.currentProbeRow here?
There was a problem hiding this comment.
update
s.currentProbeRowhere?
done
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: windtalker The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@xzhangxian1008: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #56793
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.