8000 Refactor SongCollection m_filtered and m_songs in songs.cc and add a copy SongCollection in requesthandler.cc · Issue #905 · performous/performous · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor SongCollection m_filtered and m_songs in songs.cc and add a copy SongCollection in requesthandler.cc #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HetorusNL opened this issue Aug 7, 2023 · 1 comment
Open

Refactor SongCollection m_filtered and m_songs in songs.cc and add a copy SongCollection in requesthandler.cc #905

HetorusNL opened this issue Aug 7, 2023 · 1 comment

Comments

@HetorusNL
Copy link
Member

Suggestion

This suggestion is about how the current m_songs and m_filtered SongCollections are implemented in song.cc.
Remove either m_filtered or m_songs, so having only a single SongCollection in songs.cc.
Add a duplicate SongCollection to requesthandler.cc to separate the sorting/filtering in the web server from the filtering in songs.cc.

This removes the confusion around the two SongCollections in songs.cc.
This would be the clean (refactored) implementation of PR #901 .

Use case

No response

Extra info/examples/attachments

No response
@Baklap4
Copy link
Member
Baklap4 commented Aug 7, 2023

Linking #904 since they both reside in songs.cc might be good to pick up combined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Baklap4 @HetorusNL
0