8000 Diff Time line improvement $ref / data · Issue #57 · pb33f/doctor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Diff Time line improvement $ref / data #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LasneF opened this issue May 14, 2025 · 1 comment
Open

Diff Time line improvement $ref / data #57

LasneF opened this issue May 14, 2025 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@LasneF
Copy link
LasneF commented May 14, 2025

given the actual difference / refactoring

moved from array to $ref

Image

the difference is describe like this on the right panel

Image

and like that in the center panel list

2 feedback , here it is quite difficult to understand what has really changed , and so far should not be a breaking change

to me the resolution of breaking change should be at the payload / transport level , the fact that it is modelized with $ref or not should not be a topic , difference should apply on the "extended model'
@daveshanley
Copy link
Member
daveshanley commented May 14, 2025 •
edited
Loading

good feedback. The issue lies in libopenapi, it's seeing that as a breaking change, not sure why - it's a bug for sure. The doctor needs to do a better job of showing the ref changes, agreed, this is not clear.

@daveshanley daveshanley added the help wanted Extra attention is needed label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daveshanley @LasneF
0