[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd transpose issue with lower notes #1060

Open
seisiuneer opened this issue Nov 17, 2024 · 3 comments
Open

Odd transpose issue with lower notes #1060

seisiuneer opened this issue Nov 17, 2024 · 3 comments

Comments

@seisiuneer
Copy link
Contributor
seisiuneer commented Nov 17, 2024

Reported by one of my users...

This:

X: 1
T: Bug when transposing lower notes
% accidentals for lowers notes are not good
% no problem with https://www.abctransposer.de/
M: 6/8
L: 1/8
K: C
^A=AA ^A,=A,A,|

Transposed up one semitone using ABCJS.strTranspose() results in:

X: 1
T: Bug when transposing lower notes
% accidentals for lowers notes are not good
% no problem with https://www.abctransposer.de/
M: 6/8
L: 1/8
K: Db
=B_BB =B,B,B,|

The first three notes are correct, the second three are not.

Seems very specific to the lower notes and something having to do with all the in-measure alterations.

If I separate each note into a new measure, the transpose works correctly.

@seisiuneer
Copy link
Contributor Author

Minimum repro case, transposing this up one semitone:

X: 1
T: Bug when transposing lower notes
% accidentals for lowers notes are not good
% no problem with https://www.abctransposer.de/
L: 1/8
K: C
^A,=A,|

Results in this:

X: 1
T: Bug when transposing lower notes
% accidentals for lowers notes are not good
% no problem with https://www.abctransposer.de/
L: 1/8
K: Db
=B,B,|

Should be:

X: 1
T: Bug when transposing lower notes
% accidentals for lowers notes are not good
% no problem with https://www.abctransposer.de/
L: 1/8
K: Db
=B,_B,|

@seisiuneer
Copy link
Contributor Author

This exhibits the same issue:

X: 1
T: Bug when transposing lower notes
% accidentals for lowers notes are not good
% no problem with https://www.abctransposer.de/
L: 1/8
K: C
_A,=A,|

Transposing down one semitone results in:

X: 1
T: Bug when transposing lower notes
% accidentals for lowers notes are not good
% no problem with https://www.abctransposer.de/
L: 1/8
K: B
=G,G,|

That second G should be a G#

@asjl
Copy link
asjl commented Nov 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants