8000 fix(parser): don't panic when parsing hex rationals by DaniPopes · Pull Request #256 · paradigmxyz/solar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(parser): don't panic when parsing hex rationals #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

fix(parser): don't panic when parsing hex rationals #256

merged 2 commits into from
Apr 10, 2025

Conversation

DaniPopes
Copy link
Member

Currently we reject hex rational literals in the lexer, but they are passed on to the parser which then panics.

Fixes foundry-rs/foundry#10287.

@DaniPopes DaniPopes requested a review from onbjerg as a code owner April 10, 2025 13:26
@DaniPopes DaniPopes mentioned this pull request Apr 10, 2025
Closed
2 tasks
@DaniPopes DaniPopes merged commit 05f881b into main Apr 10, 2025
14 checks passed
@DaniPopes DaniPopes deleted the dani/hex-rat branch April 10, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing to compile contracts
1 participant
@DaniPopes
0