8000 Bitshift Left Instructions · Issue #3 · pRain1337/plouton · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bitshift Left Instructions #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
r1cky33 opened this issue Apr 10, 2025 · 2 comments
Closed

Bitshift Left Instructions #3

r1cky33 opened this issue Apr 10, 2025 · 2 comments
Assignees
@pRain1337

Comments

@r1cky33
Copy link
r1cky33 commented Apr 10, 2025

Hi, i just wanted to point out, that here: https://github.com/pRain1337/plouton/tree/main/Plouton-UEFI/Plouton/hardware#endpoints

Type: Offset 0x4, 8-bit value, perform a left shift 3 for the correct value.

We are talking about a right shift, don't we?
The picture shows a value of 0x3e on the offset 0x4. 0x3e >> 3 equals 7, which equals the parameter in the code. (logitech_g_pro.c#53)
@pRain1337 pRain1337 self-assigned this Apr 12, 2025
@pRain1337
Copy link
Owner

Hi, thank you for noticing, you are absolutely right.

I fixed it in the readme already and also added a reference to the Intel XHCI specification.
I'll also add the proper references why right shift etc. in the code later :-)

@pRain1337
Copy link
Owner

Changed documentation and added better comments in code that actually links to the Intel XHCI specification.
Documentation now also reflects the possible multi-support of XHCI controllers by actually properly parsing it, more info in this issue.
The code documentation is currently in the multi-XHCI branch, where we extended support to non-Intel XHCI controllers.
Right now pending a review by @jussihi.

I'll close this issue for now, thanks again for pointing out the error :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pRain1337 pRain1337

Labels
None yet
Projects
38B2
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pRain1337 @r1cky33
0