8000 can't change the "HighLight Word" color · Issue #690 · pyscripter/pyscripter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

can't change the "HighLight Word" color #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GoogleCodeExporter opened this issue Aug 24, 2015 · 4 comments
Closed

can't change the "HighLight Word" color #690

GoogleCodeExporter opened this issue Aug 24, 2015 · 4 comments
Labels
auto-migrated fixed

Comments

@GoogleCodeExporter
Copy link 
What steps will reproduce the problem?
1. In windows' display settings -> appearance -> advance, select the item 
Window, set the foreground to Yellow R: 255 G: 255 B: 0.
2. type two lines containing the same word
3. double click on one of the word, they are unreadable (background and 
foreground are same color)

What is the expected output? What do you see instead?
IDE should give a possibility to change the "HighLight Word" color.

What version of the product are you using? On what operating system?
2.5.3.0 x86

Please provide any additional information below.
Seems the "HighLight Word" color is hard coded.
See the file uSearchHighlighter.pas -> class THighlightSearchPlugin -> method 
AfterPaint -> procedure PaintHightlight (l.59):
ACanvas.Brush.Color := clYellow;

Original issue reported on code.google.com by philippe...@gmail.com on 17 Sep 2012 at 4:43
@stephenpjohnson34
Copy link
stephenpjohnson34 commented Oct 31, 2017 •
edited
Loading

It's October 2017, I'm using version 3.0.2.0 and this is still a problem. This highlight feature forces a yellow background with no options to customize it and completely disregards the text color. I am using a dark text theme that uses a light grey font on a dark blue background. When word highlighting changes the background yellow but leaves the text grey, it becomes unreadable. You need to fix this by either enforcing a dark text color when you force a yellow highlight, or allow the user to customize the highlight color. Until this is fixed, you're basically forcing people away from dark themes.

EDIT: I was mistaken. The yellow background with grey text is used for all themes, dark or light. The fact that my theme used grey text and so did the highlighter was only a coincidence. So....basically the feature is that when you select a word using the editor, the editor makes all other instances of that word unreadable by changing it to grey on yellow. What a terrible feature =/

@pyscripter
Copy link
Owner

Will be fixed in the next version.
ABEE

@pyscripter pyscripter reopened this Oct 31, 2017
@pyscripter
Copy link
Owner

Fixed in repository.

pyscripter added a commit that referenced this issue Nov 2, 2017
@pyscripter
Fixed issue #690
a0d9791
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pyscripter @stephenpjohnson34 @GoogleCodeExporter
0