8000 Fix improper use of "is" and "is not" with literals · Issue #130 · pygeode/pygeode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Fix improper use of "is" and "is not" with literals #130
Open
@neishm

Description

@neishm

Python 3.8 added a SyntaxWarning whenever an "is" / "is not" comparison is done against a literal. (see https://docs.python.org/3.8/whatsnew/3.8.html#changes-in-python-behavior and https://bugs.python.org/issue34850). Apparently PyGeode has these kinds of comparisons sprinkled through the code, because the screen gets filled with such warnings when running it under Python 3.8. These comparisons (when done against literals) should be changed to == and != for correct behaviour (especially if running in a non-CPython interpreter).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0