8000 Revert updating address dropdown when Drupal ajax request completes · Issue #112 · localgovdrupal/localgov_forms · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
< 8000 /div>

Revert updating address dropdown when Drupal ajax request completes #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andybroomfield opened this issue Mar 27, 2025 · 2 comments
Closed

Revert updating address dropdown when Drupal ajax request completes #112

andybroomfield opened this issue Mar 27, 2025 · 2 comments
Assignees
@PardeepSinghBali

Comments

@andybroomfield
Copy link
Contributor

Now that Fixing ID randomization but keeping the stable selector #731 has been merged, we need to revert or remove this change in localgov_forms.

Thanks for providing this fix. I have had a look now. This change is attempting to fix a long standing issue with the localgovdrupal/localgov_base#325 (comment). I would request that you revert this change and try to fix localgov_base.

While this fix works for one Address lookup element, it breaks when there are more than one :(

Confirming that with 1.x branch checked out, this causes the issue where the address lookup is updated for all addresses when more than one on a single webform.
@andybroomfield
Copy link
Contributor Author

@PardeepSinghBali I've assigned you as I don't have permission on this repo to revert it in the UI. I think it will need to be done via command line if you could take a look.

@PardeepSinghBali
Copy link
Contributor

a PR is generated Reverting the change #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PardeepSinghBali PardeepSinghBali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andybroomfield @PardeepSinghBali
0