From 3b2c4462bdd854c65ef5b0e6ec8b0e9dff04c3fa Mon Sep 17 00:00:00 2001 From: Russell Bicknell Date: Fri, 30 Oct 2020 17:52:38 -0700 Subject: [PATCH 1/2] Remove a `test.only` in the lit-html tests. --- packages/lit-html/src/test/lit-html_test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/lit-html/src/test/lit-html_test.ts b/packages/lit-html/src/test/lit-html_test.ts index 3609b75764..c3fc42be39 100644 --- a/packages/lit-html/src/test/lit-html_test.ts +++ b/packages/lit-html/src/test/lit-html_test.ts @@ -1731,7 +1731,7 @@ suite('lit-html', () => { assert.strictEqual((container.firstElementChild as any).foo, 'A:1'); }); - test.only('renders directives on EventParts', () => { + test('renders directives on EventParts', () => { const handle = directive( class extends Directive { count = 0; From 0559f0fc287380f94632db9152637dabee4f00ca Mon Sep 17 00:00:00 2001 From: Kevin Schaaf Date: Mon, 2 Nov 2020 15:10:14 -0800 Subject: [PATCH 2/2] Restore coercing null/undefined to empty string when concatenating --- packages/lit-html/src/lit-html.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/lit-html/src/lit-html.ts b/packages/lit-html/src/lit-html.ts index 775e656837..7e20939dd0 100644 --- a/packages/lit-html/src/lit-html.ts +++ b/packages/lit-html/src/lit-html.ts @@ -1181,7 +1181,7 @@ export class AttributePart { (this._value as Array)[i] = v; } attributeValue += - (typeof v === 'string' ? v : String(v)) + strings[i + 1]; + (typeof v === 'string' ? v : String(v ?? '')) + strings[i + 1]; } if (change && !noCommit) { this._commitValue(remove ? nothing : attributeValue);