8000 --disable-doc is not parsed correctly by configure · Issue #394 · linbox-team/fflas-ffpack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

--disable-doc is not parsed correctly by configure #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saraedum opened this issue Apr 19, 2024 · 0 comments
Open

--disable-doc is not parsed correctly by configure #394

saraedum opened this issue Apr 19, 2024 · 0 comments

Comments

@saraedum
Copy link
saraedum commented Apr 19, 2024

Currently, configure --disable-doc makes fflas-ffpack try to build the documentation. The reason is that AC_ARG_ENABLE is not used correctly; that's because it's AC_ARG_ENABLE(name, help, help, present, missing) and not AC_ARG_ENABLE(name, help, help, enable, disable). Something like this should fix it:

diff --git a/macros/fflas-ffpack-doc.m4 b/macros/fflas-ffpack-doc.m4
index c225398..6adb7fe 100644
--- a/macros/fflas-ffpack-doc.m4
+++ b/macros/fflas-ffpack-doc.m4
@@ -47,25 +47,26 @@ AC_ARG_WITH(doxygen,
                DOXYGEN_PATH="$PATH"
            ])

-AC_ARG_ENABLE(doc,[AC_HELP_STRING([--enable-doc], [Enable building documentation])],
-[
-AC_MSG_RESULT(yes)
-AC_MSG_CHECKING(whether doxygen works)
-export PATH=$DOXYGEN_PATH
-(doxygen --version) < /dev/null > /dev/null 2>&1 || {
-       AC_MSG_RESULT(no)
-       echo
-       echo "You must have doxygen installed to create documentation for"
-       echo "FFLAS-FFPACK. This error only happens if you use --enable-doc."
-       echo "Download the appropriate package for your distribution, or get"
-       echo "the source tarball from http://www.stack.nl/~dimitri/doxygen/"
-       exit -1
-}
-AC_MSG_RESULT(yes)
-AM_CONDITIONAL(FFLASFFPACK_BUILD_DOC, true)
-],
-[
-AC_MSG_RESULT(no)
-AM_CONDITIONAL(FFLASFFPACK_BUILD_DOC, false)
-])
+AC_ARG_ENABLE(doc,[AC_HELP_STRING([--enable-doc], [Enable building documentation])])
+
+AS_IF([test x"$enable_doc" != "xno"],[
+  enable_doc=yes
+  AC_MSG_RESULT(yes)
+  AC_MSG_CHECKING(whether doxygen works)
+  export PATH=$DOXYGEN_PATH
+  (doxygen --version) < /dev/null > /dev/null 2>&1 || {
+    AC_MSG_RESULT(no)
+    echo
+    echo "You must have doxygen installed to create documentation for"
+    echo "FFLAS-FFPACK. This error only happens if you use --enable-doc."
+    echo "Download the appropriate package for your distribution, or get"
+    echo "the source tarball from http://www.stack.nl/~dimitri/doxygen/"
+    exit -1
+  }
+  AC_MSG_RESULT(yes)
+  AM_CONDITIONAL(FFLASFFPACK_BUILD_DOC, true)
+], [
+  AC_MSG_RESULT(no)
 ])
+
+AM_CONDITIONAL(FFLASFFPACK_BUILD_DOC, [test "x$enable_doc" = "xyes"])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant
0