8000 fix: updated keycloak init container version rendering by Ani1357 · Pull Request #2108 · linode/apl-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: updated keycloak init container version rendering #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 30, 2025
Merged

fix: updated keycloak init container version rendering #2108

merged 5 commits into from
Apr 30, 2025

Conversation

Ani1357
Copy link
Contributor
@Ani1357 Ani1357 commented Apr 29, 2025

📌 Summary

With this PR we can be more consistent in setting versions for our tools. Now consoleLogin accepts a version tag without the v prefix as the other components.

🔍 Reviewer Notes

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 29, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements
48.98% (+0.09% 🔼)
 1061/2166
🔴 Branches
33.07% (+0.47% 🔼)
 212/641
🔴 Functions
40.67% (+0.33% 🔼)
 122/300
🔴 Lines
48.3% (+0.1% 🔼)
 938/1942

Test suite run success

92 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from f254a57

j-zimnowoda
j-zimnowoda requested changes Apr 30, 2025
View reviewed changes
Copy link
Contributor
@j-zimnowoda j-zimnowoda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for consoleLogin: 1.1.1-rc.1
but
It does not work for consoleLogin: 1.1.1

Although it is not entirely correct, I see that we have successfully used the following statement:

{{- $isSemver := regexMatch "^[0-9.]+" $version }}

@Ani1357 Ani1357 requested a review from j-zimnowoda April 30, 2025 08:42
@j-zimnowoda j-zimnowoda merged commit ce8f4f0 into main Apr 30, 2025
7 checks passed
@j-zimnowoda j-zimnowoda deleted the versions_consistency branch April 30, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-zimnowoda j-zimnowoda j-zimnowoda approved these changes

@CasLubbers CasLubbers CasLubbers approved these changes

@ElderMatt ElderMatt Awaiting requested review from ElderMatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ani1357 @j-zimnowoda @CasLubbers @svcAPLBot
0