8000 feat: static team settings page by dennisvankekem · Pull Request #2024 · linode/apl-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: static team settings page #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Apr 17, 2025
Merged

feat: static team settings page #2024

merged 27 commits into from
Apr 17, 2025

Conversation

dennisvankekem
Copy link
Contributor
@dennisvankekem dennisvankekem commented Mar 31, 2025 •
edited
Loading

PRs:

console: https://github.com/linode/apl-console/pull/531
api: https://github.com/linode/apl-api/pull/672
core: #2024

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 31, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements
48.74% (+0.83% 🔼)
 1046/2146
🔴 Branches
32.7% (+1.68% 🔼)
 208/636
🔴 Functions
39.86% (+0.96% 🔼)
 118/296
🔴 Lines
48.05% (+0.88% 🔼)
 924/1923

Test suite run success

92 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 85b47d2

@dennisvankekem dennisvankekem marked this pull request as ready for review April 4, 2025 13:06
@dennisvankekem dennisvankekem changed the title feat: replaced regex patterns for strings feat: static team settings page Apr 4, 2025
@CasLubbers CasLubbers self-assigned this Apr 7, 2025
@CasLubbers CasLubbers self-requested a review April 7, 2025 11:44
CasLubbers
CasLubbers requested changes Apr 7, 2025
View reviewed changes
Copy link
Contributor
@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a migration script for existing teams

j-zimnowoda
j-zimnowoda reviewed Apr 8, 2025
View reviewed changes
j-zimnowoda
j-zimnowoda previously requested changes Apr 8, 2025
View reviewed changes
Copy link
Contributor
@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After running npm run migrate I do not see any migration. This PR should reflect the migration in tests fixtures.

ferruhcihan
ferruhcihan requested changes Apr 8, 2025
View reviewed changes
@ferruhcihan ferruhcihan self-requested a review April 8, 2025 12:53
ferruhcihan
ferruhcihan reviewed Apr 8, 2025
View reviewed changes
ferruhcihan
ferruhcihan reviewed Apr 8, 2025
View reviewed changes
ferruhcihan
ferruhcihan reviewed Apr 8, 2025
View reviewed changes
dennisvankekem
dennisvankekem commented Apr 9, 2025
View reviewed changes
@dennisvankekem
Copy link
Contributor Author

The proposed resourceQuota is not compatible.

  • Decorator and mutable needs to be removed from the ResourceQuota object and need to be implemented in the console
  • loadbalancers is nodeports don't have the services. in front of them
  • compute resource quotas are send as numbers but should be send in the right notation (e.g. cpu should be 500m instead of just 500)
  • enabled flag needs to be removed

To reflect this:

  • ResourceQuota data structure needs to be reverted
  • Console needs to map the keys to decorator and mutable fields
  • additions in migration for resourceQuota need to be removed
  • ResourceQuota enabled checkbox can be removed

@dennisvankekem dennisvankekem marked this pull request as draft April 10, 2025 12:39
@dennisvankekem dennisvankekem marked this pull request as ready for review April 14, 2025 14:52
CasLubbers
CasLubbers reviewed Apr 16, 2025
View reviewed changes
@dennisvankekem dennisvankekem dismissed j-zimnowoda’s stale review April 17, 2025 09:17

Changes have been resolved

@dennisvankekem dennisvankekem merged commit b6c66b1 into main Apr 17, 2025
7 checks passed
@dennisvankekem dennisvankekem deleted the APL-540 branch April 17, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasLubbers CasLubbers CasLubbers approved these changes

@ferruhcihan ferruhcihan ferruhcihan approved these changes

@j-zimnowoda j-zimnowoda Awaiting requested review from j-zimnowoda j-zimnowoda is a code owner

Assignees

@CasLubbers CasLubbers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dennisvankekem @j-zimnowoda @CasLubbers @ferruhcihan @ElderMatt
0