8000 feat: new file structures that is more compatible with gitops approach by j-zimnowoda · Pull Request #1930 · linode/apl-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: new file structures that is more compatible with gitops approach #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 154 commits into from
Mar 17, 2025
Merged

feat: new file structures that is more compatible with gitops approach #1930

merged 154 commits into from
Mar 17, 2025

Conversation

j-zimnowoda
Copy link
Contributor
@j-zimnowoda j-zimnowoda commented Feb 6, 2025 •
edited by CasLubbers
Loading

Changes:

  • Use the new file structure for bootstrapping
  • Migrate old file structure to the new file structure

Corresponding API and Console PR's:

@j-zimnowoda
feat: get teams by direcotry name
db70af5
@j-zimnowoda
feat: save teams
b909211
@j-zimnowoda
feat: save team values
a9bd470
@j-zimnowoda
feat: save team values
6d434e8
@j-zimnowoda
fix: get teams
d5ab314
@j-zimnowoda
feat: loadTeam
5d902f7
@j-zimnowoda
feat: loadTeam
0f1b7e6
@j-zimnowoda
feat: loadTeam
58cda44
@j-zimnowoda
feat: loadTeam
dc71b73
@j-zimnowoda
feat: use team settings property
46ed70d
@j-zimnowoda
feat: take into account decrypted file
aefd27a
@j-zimnowoda
test: loadTeamFileToSpec
bf74382
@j-zimnowoda
test: loadTeam
d6c5e15
@j-zimnowoda
test: loadTeam
50a6334
@j-zimnowoda
docs: loadTeam
275ff42
@j-zimnowoda
docs: loadTeam
0da4b69
@j-zimnowoda
docs: loadTeam
5e3e5dc
@j-zimnowoda
docs: loadTeam
ab4d74b
@j-zimnowoda
docs: loadTeam
0b76d95
@j-zimnowoda
feat: getTeamConfig
ada00b8
@j-zimnowoda
feat: remove unused variables
9e45f2a
@j-zimnowoda
fix: saveTeams filename agnostic
dfae516
@j-zimnowoda
fix: function naming
441190c
@j-zimnowoda
fix: load team
d0aebc8
@j-zimnowoda
fix: load team
3eb174a
@j-zimnowoda
fix: loading the admin team
61964a9
@j-zimnowoda
refactor: rename module
8152534
@j-zimnowoda
fix: file name parsing
e598d31
@j-zimnowoda
fix: do not rely on teams.yaml file
c75ce6a
@j-zimnowoda
refactor: move loading and saving teams to repo module
8b1cd55
j-zimnowoda and others added 4 commits March 4, 2025 09:46
@j-zimnowoda @CasLubbers
fixL update src/common/hf.ts
d28f718 
Co-authored-by: CasLubbers <clubbers@akamai.com>
@j-zimnowoda @CasLubbers
fix: update src/common/repo.ts
82fbeee 
Co-authored-by: CasLubbers <clubbers@akamai.com>
@j-zimnowoda @CasLubbers
fix: update src/common/repo.ts
4801052 
Co-authored-by: CasLubbers <clubbers@akamai.com>
@j-zimnowoda
Merge branch 'APL-502-all' of https://github.com/linode/apl-core into…
1209cfd 
… APL-502-all
ferruhcihan
ferruhcihan reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor
@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested with some labs. Please check the comment in the ticket.

j-zimnowoda
j-zimnowoda commented Mar 7, 2025
View reviewed changes
ferruhcihan
ferruhcihan reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor
@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to remove the id fields from most of the test/fixtures files. Besides that it looks great, tested locally and on a cluster, LGTM 👍🏻

@CasLubbers
Copy link
Contributor

Can be merged after the new 4.4.0 release

@j-zimnowoda j-zimnowoda merged commit 8e15923 into main Mar 17, 2025
8 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-502-all branch March 17, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasLubbers CasLubbers CasLubbers approved these changes

@ferruhcihan ferruhcihan ferruhcihan approved these changes

@merll merll Awaiting requested review from merll merll is a code owner

@Ani1357 Ani1357 Awaiting requested review from Ani1357 Ani1357 is a code owner

Assignees

@CasLubbers CasLubbers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j-zimnowoda @CasLubbers @merll @ferruhcihan
0