8000 Review Documentation · Issue #148 · liblogicalaccess/liblogicalaccess · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Review Documentation #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xinthose opened this issue Dec 21, 2017 · 2 comments
Open

Review Documentation #148

xinthose opened this issue Dec 21, 2017 · 2 comments
Labels
code enhancement

Comments

@xinthose
Copy link

https://github.com/islog/liblogicalaccess/blob/34c3335d6c23d22dfc932e64116928dc8f80ac87/plugins/pluginscards/mifareultralight/mifareultralightcommands.hpp#L68

    /**
     * \brief Write a whole page.
     * \param sector The page number, from 0 to 15.
     * \param buf A buffer to from which to copy the data.
     * \param buflen The length of buffer. Must be at least 4 bytes long or the call will fail.
     * \return The number of bytes written, or a negative value on error.
     */

There is no return from the void function.
@Liryna Liryna changed the title Mifare Ultralight writePage Review Documenation Dec 22, 2017
@Liryna Liryna changed the title Review Documenation Review Documentation Dec 22, 2017
@Liryna
Copy link
Contributor
Liryna commented Dec 22, 2017

Hi @xinthose ,,

Thank you for the report.
I have rename the issue because this is not only linked to ultralight. We shouled review all the documentation of LLA.

@xinthose
Copy link
Author

@Liryna You're welcome ma'am. I have seen the same thing you have said: inconsistent documentation (or incorrect functions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Maxhy @Liryna @xinthose
0