8000 software checksum calculation fails when using vlan tags without offloading · Issue #9 · libmoon/libmoon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

software checksum calculation fails when using vlan tags without offloading #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
emmericp opened this issue Oct 13, 2016 · 2 comments
Open

software checksum calculation fails when using vlan tags without offloading #9

emmericp opened this issue Oct 13, 2016 · 2 comments
Assignees
@scholzd

Comments

@emmericp
Copy link
Member

The code assumes a hardcoded offset of 50/60 (IPv4/6) for the payload data which is wrong if there is a vlan tag that is not offloaded.

This is relevant for encapsulated packets.

Maybe we need a generic way to determine offsets within stacks?
@emmericp
Copy link
Member Author

Related: calling tcp:calculateChecksum() on encapsulated inner packets is slightly inconvenient because it requires a pointer to the right offset in the outer packet.

@emmericp
Copy link
Member Author

is this fixed in the refactored stack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scholzd scholzd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emmericp @scholzd
0