8000 Allow data reuse when extending a dataset · Issue #762 · lenskit/lkpy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow data reuse when extending a dataset #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mdekstrand opened this issue May 20, 2025 · 0 comments
Open

Allow data reuse when extending a dataset #762

mdekstrand opened this issue May 20, 2025 · 0 comments
Labels
data Data management support.

Comments

@mdekstrand
Copy link
Member

Using a DatasetBuilder to extend an already-assembled Dataset should be able to allow the initial data set's storage to be reused.

Right now, the code does not do that very well, because MatrixRelationshipSet._init_structures calls combine_chunks on the table. If my memory is correct, this was to simplify some Rust optimizations.

To improve memory use, we should remove that combine_chunks call and fix whatever breaks to enable data reuse.

We should also add more tests using data set extension to make sure the code is well-exercised.
@mdekstrand mdekstrand added the data Data management support. label May 20, 2025
@mdekstrand mdekstrand moved this to Backlog in LensKit Development May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data Data management support.
Projects
LensKit Development
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdekstrand
0