8000 Distribution · Issue #26 · krisnova/krex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Distribution #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
scottrigby opened this issue Jul 6, 2018 · 3 comments
Open

Distribution #26

scottrigby opened this issue Jul 6, 2018 · 3 comments

Comments

8000
@scottrigby
Copy link
Contributor

May be a good place to discuss things like dep, go get, the vendor dir, an installation section in the readme, release binaries, etc?

Also want to mention https://github.com/goreleaser/goreleaser, which may resolve ALL THE THINGS?
@scottrigby scottrigby mentioned this issue Jul 6, 2018
Merged
@scottrigby
Copy link
Contributor Author

So I talked with Sam B, and yes – if you want ppl to use a dep-managed project with go get, the easiest way is committing all the vendor files. The downside is PRs can have lots of dependency files to sort through, and the overall repo size is larger than necessary.

For comparison sake, I set up an example project with external dependencies, using goreleaser, and dep with the no vendor directory commit strategy. It's kind of a neat recipe, and I'm happy to set that up on this repo if you think that fits what you're looking for in terms of ease of use? https://github.com/scottrigby/test-goreleaser

I didn't set up a homebrew tap yet for this, but it's an easy to setup optional feature of goreleaser.

@frezbo
Copy link
Contributor
frezbo commented Jul 8, 2018 •
edited
Loading

For other languages the standard followed is not to commit the dependencies directory, still I see a lot of Golang projects with the vendor directory committed. Is it just to support the go get model?. I could argue this is an anti-pattern. It makes reviewing and code management very hard. Correct me if I'm wrong.

@scottrigby
Copy link
Contributor Author

I updated that example project with some better info (and renamed it to be hopefully more clear): https://github.com/scottrigby/example-dep-no-vendor

@scottrigby scottrigby mentioned this issue Jul 9, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scottrigby @frezbo
0