Node18 tls fix #168
Open
Node18 tls fix #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 18 appears to reject connections to the Roomba as it doesn’t support Secure Renegotiation. See https://www.openssl.org/docs/man1.1.1/man3/SSL_clear_options.html (search for SSL_OP_LEGACY_SERVER_CONNECT)
|
hey, thanks for this. You are upgrading mqtt 2 to 4 which has breaking changes. Looks like are just upgrading the package version without implementing the required changes to handle new error management. (see https://github.com/mqttjs/MQTT.js#notes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TLS connection to Roomba is broken on Node 18 as Roomba doesn't appear to support Secure Renegotiation.
The TLS connection in
mqttfails with the error:When we enable legacy server connect, we are able to successfully connect. See https://www.openssl.org/docs/man1.1.1/man3/SSL_clear_options.html for more information(search for SSL_OP_LEGACY_SERVER_CONNECT).