8000 Task: All tests to date pass on Oracle 18c · Issue #4890 · knex/knex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Task: All tests to date pass on Oracle 18c #4890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
17 of 34 tasks
code-ape opened this issue Dec 13, 2021 · 0 comments
Open
17 of 34 tasks

Task: All tests to date pass on Oracle 18c #4890

code-ape opened this issue Dec 13, 2021 · 0 comments

Comments

@code-ape
Copy link
Collaborator
code-ape commented Dec 13, 2021 •
edited by OlivierCavadenti
Loading

Overview

What: It was recently found with the addition of CI tests for Oracle 18c (#4888 and #4889) that not all tests are passing for it. This should be fixed for proper functionality on changes and releases.

Why: CI has not run for Oracle for over a year since Travis CI shutdown their free OSS tier in November 2020.

How: All broken tests are listed below in check list form to track their resolution.

Tests to Fix

Current status: 304 passing, 61 pending, 34 failing. All known failing listed below with failure summary.

  • Inserts / oracledb /
    • should handle multi inserts
      • Failure: AssertionError: expected [ '2', '3' ] to deeply equal [ '1', '2' ]
    • should take hashes passed into insert and keep them in the correct order
      • Failure: AssertionError: expected [ '4', '5' ] to deeply equal [ '1', '2' ]
    • should drop any where clause bindings
      • Failure: AssertionError: expected [ '8' ] to deeply equal [ '1' ]
    • should take an array of columns to return in oracle or postgres
      • Expected: "test_table_two" ("account_id", "details", "status") values (?, ?, ?) returning "account_id","details" into ?,?' to equal 'insert into "test_table_two"
      • Received: "insert into "test_table_two" ("account_id", "details", "status")\n values (?, ?, ?) returning "account_id","details"\n into ?,?"
    • should allow a * for returning in postgres and oracle
      • Failure: Array of element 1 different in object key id, expected 4 got 1.
  • Additional / oracledb /
    • other operations / should insert binary uuid and retreive it (typo in word "retreive")
      • Error: create table "uuid_table" ("uuid_col_binary" binary(16)) - ORA-00907: missing right parenthesis
  • Joins / oracledb /
    • has a leftJoin method parameter to specify the join type
      • Failure: Numerous differences in objects returned. Specifically id and details fields.
    • supports join aliases with advanced joins
      • Failure: Different object returned.
  • Selects / oracledb /
    • returns an array of a single column with pluck
      • Failure: AssertionError: expected [ 7, 8, 9, 10, 11, 12 ] to deeply equal [ 1, 2, 3, 4, 5, 6 ]
    • can pluck a qualified column name, Pluck not working for explicit column names #1619
      • Failure: AssertionError: expected [ 13, 14, 15, 16, 17, 18 ] to deeply equal [ 1, 2, 3, 4, 5, 6 ]
    • starts selecting at offset:
      • Failure: AssertionError: expected [ 21, 22, 23, 24 ] to deeply equal [ 3, 4, 5, 6 ]
    • Support for MySQL optimizer hints #4199 - ignores invalid hint comments
      • Failure: All elements in array have different id
    • returns a single entry with first
      • Failure: Different id for return value.
    • uses "orderBy"
      • Failure: Different ids returned.
    • order by with null:
      • Failure Error: select "id" from "OrderByNullTest" order by ("null_col" is not null) asc - ORA-00907: missing right parenthesis
  • unions / oracledb /
    • handles unions with a callback
      • Failure: Error: ORA-00932: inconsistent datatypes: expected - got CLOB
    • handles unions with an array of callbacks
      • Failure: Error: ORA-00932: inconsistent datatypes: expected - got CLOB
    • handles unions with a list of callbacks
      • Failure: Error: ORA-00932: inconsistent datatypes: expected - got CLOB
    • handles unions with an array of builders
      • Failure: Error: ORA-00932: inconsistent datatypes: expected - got CLOB
    • handles unions with a list of builders
      • Failure: Error: ORA-00932: inconsistent datatypes: expected - got CLOB
    • handles unions with a raw query
      • Failure: Error: ORA-00932: inconsistent datatypes: expected - got CLOB
    • handles unions with an array raw queries
      • Failure: Error: ORA-00932: inconsistent datatypes: expected - got CLOB
    • handles unions with a list of raw queries
      • Failure: Error: ORA-00932: inconsistent datatypes: expected - got CLOB
  • Where / oracledb / simple "where" cases /
    • allows key, value
      • Failure: Didn't return an object
    • allows key, operator, value
      • Failure: Didn't return an object
    • allows a hash of where attrs
      • Failure: Didn't return an object
  • Updates / oracledb /
    • should allow returning for updates
      • Failure: AssertionError: expected 55 to deeply equal 1
  • Schema (misc) / oracledb / createTable /
    • accepts the table name, and a "container" function
      • Failure: Query generated with differing newlines.
    • create table with timestamps options
      • Failure: Significant differences in query generated, unsure how to summarize.
  • Schema (misc) / oracledb / table /
    • allows changing a field
      • Failure: Error: alter table "test_table_one" add "phone" varchar2(255) null - ORA-00942: table or view does not exist
    • allows dropping a index
      • Failure: Error: drop index "NkZo/dGRI9O73/NE2fHo+35d4jk" - ORA-01418: specified index does not exist
  • Schema (misc) / oracledb / renameTable /
    • renames the table from one to another
      • Failure: ORA-04043: object test_table_one does not exist
  • Schema (misc) / oracledb / hasColumn / without processors /
    • checks whether a column exists, resolving with a boolean
      • Failure: AssertionError: expected false to equal true
  • Views / oracledb / view
    • create materialized view
      • Failure: ORA-20000: ORA-01031: insufficient privileges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code-ape
0