[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pod.TerminationGracePeriodSeconds setting #15599

Open
V2arK opened this issue Oct 29, 2024 · 3 comments
Open

pod.TerminationGracePeriodSeconds setting #15599

V2arK opened this issue Oct 29, 2024 · 3 comments
Labels
kind/feature Well-understood/specified features, ready for coding.

Comments

@V2arK
Copy link
V2arK commented Oct 29, 2024

Describe the feature

Right now TerminationGracePeriodSeconds is set to rev.Spec.TimeoutSeconds

https://github.com/knative/serving/blob/main/pkg/reconciler/revision/resources/deploy.go#L304

However, rev.Spec.TimeoutSeconds also specifies the timeout for in-flight request.

I think these two values should be seperated, because in my project, I want to terminate deployment without graceful exit, but I want the timout for in-flight request to be as long as possible.

@V2arK V2arK added the kind/feature Well-understood/specified features, ready for coding. label Oct 29, 2024
@skonto
Copy link
Contributor
skonto commented Oct 30, 2024

I want to terminate deployment without graceful exit, but I want the timout for in-flight request to be as long as possible.

Hi @V2arK, this was added years ago so there is a guarantee about connections not to be dropped during autoscaling. The knative autoscaler continuously makes decisions about the deployment scale and that may interrupt connections during pod shutdown.
Could you elaborate on your use case, you don't care about failing requests?

@V2arK
Copy link
Author
V2arK commented Oct 31, 2024

Hi @skonto, in my uses cases I just want to terminates the pods ASAP (maybe 3~5 seconds) when I triggers the termination, but not to change the timeout for requests (eg, LLM spits out response in minutes),

@skonto
Copy link
Contributor
skonto commented Nov 27, 2024

Hi @V2arK

when I triggers the termination

How do you trigger that? You are removing the knative service? Could you just drop the connection when a SIGTERM is received at the LLM python runtime or at the client side too? If you interrupt the connections, draining will happen pretty fast as QP will not wait for them to finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Development

No branches or pull requests

2 participants