8000 dubious check in redis store · Issue #19 · knadh/niltalk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
dubious check in redis store #19
Closed
@clementauger

Description

@clementauger

hey,

in the redis store GetSession method, the statement that verifies that the retrieved handle form redis is not empty is dubious.

In the case the user has not provided an username, which he might do, then the session he opened can never be retrieved.

See this line https://github.com/knadh/niltalk/blob/master/store/redis/redis.go#L164

I have not run manual testing to check for it, though i had to remove the corresponding statement in the memory store i have written.

So i guess this applies to the redis store too.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0