[WIP] Add LED footprints for MX #40
Conversation
| self.append(Pad(number=1, type=Pad.TYPE_THT, shape=Pad.SHAPE_CIRCLE, | ||
| at=[-1.27, 5.08], size=[1.905, 1.905], drill=1.04, | ||
| layers=['*.Cu', 'B.Mask'])) | ||
| self.append(Pad(number=2, type=Pad.TYPE_THT, shape=Pad.SHAPE_CIRCLE, | ||
| at=[1.27, 5.08], size=[1.905, 1.905], drill=1.04, | ||
| layers=['*.Cu', 'B.Mask'])) |
There was a problem hiding this comment.
Dimensions based on MX_Alps_Hybrid, I've had success with these dimensions in the past:
https://github.com/ai03-2725/MX_Alps_Hybrid/blob/master/MX_Only.pretty/MXOnly-1.25U.kicad_mod#L23-L24
|
this is not really the approach I was looking to implement, to start with I would like to have the space available for leds labeled on the switch, this is an interesting idea, but with so much variation between switches, and the different leds available, i dont think its viable, we would have to generate a large amount of footprints, and it would be confusing |
Having the locations marked on a user layer in the actual switch footprint is an option, but imo it's not that great for actually making keyboards
As for the different types of LEDs, I'm not aware of any other type of LED that someone might want to put into/under a switch; the current ones I've proposed should be fairly straightforward, and even then it should be obvious what the outcome will look like if we have 3d models. |
|
I changed my mind on how I want this to work, I want to have the LEDs embedded in the footprint, behaving like the keycaps do right now in the scripts, they wont be included in the default library but will be generate-able now manually, and later through the TODO plugin |
Relates to #23
For now this is implemented as a completely different footprint that the user would overlay on top of the keyswitch footprint.
There's also the option to have the LEDs baked into the keyswitch footprint like it is in MX_Alps_Hybrid, although that will require a custom symbol containing LED and Switch together, not sure which approach is preferred, or both.
TODO: