8000 Adopt controller-runtime client · Issue #8355 · kiali/kiali · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adopt controller-runtime client #8355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nrfox opened this issue Apr 21, 2025 · 0 comments · Fixed by #8389
Closed

Adopt controller-runtime client #8355

nrfox opened this issue Apr 21, 2025 · 0 comments · Fixed by #8389
Assignees
@nrfox
Labels
enhancement This is the preferred way to describe new end-to-end features.

Comments

@nrfox
Copy link
Contributor
nrfox commented Apr 21, 2025

What do you want to improve?

Kiali has a homegrown kube cache implementation that offers an abstraction over managing informers and listers. Controller-runtime has its own cache abstraction that does all the things that Kiali needs and it makes it easier to integrate into controllers. Kiali already uses controller-runtime to manage the validation controller but does not use controller-runtime client/cache. Without adopting the controller-runtime client/cache, it is more difficult to develop new controllers and for the validation controller to do per object validations. We also do not want to use two different sets of informers (Kiali home grown cache and controller-runtime cache) since we could end up caching the same objects twice.
@nrfox nrfox added the enhancement This is the preferred way to describe new end-to-end features. label Apr 21, 2025
@nrfox nrfox self-assigned this Apr 21, 2025
@nrfox nrfox mentioned this issue Apr 30, 2025
Merged
@nrfox nrfox moved this from 📋 Backlog to 🏗 In progress in Kiali Sprint 25-08 | Kiali v2.10 Apr 30, 2025
This was referenced May 2, 2025
Open
Open
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Kiali Sprint 25-08 | Kiali v2.10 May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nrfox nrfox

Labels
enhancement This is the preferred way to describe new end-to-end features.
Projects
Kiali Sprint 25-08 | Kiali v2.10
3F4A
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace kubecache with controller-runtime cache nrfox/kiali
1 participant
@nrfox
0