8000 [hack-scripts][test] Support customized istio control plane namespace · Issue #7951 · kiali/kiali · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ kiali Public

[hack-scripts][test] Support customized istio control plane namespace #7951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mkralik3 opened this issue Nov 21, 2024 · 4 comments
Closed

[hack-scripts][test] Support customized istio control plane namespace #7951

mkralik3 opened this issue Nov 21, 2024 · 4 comments
Labels
enhancement This is the preferred way to describe new end-to-end features.

Comments

@mkralik3
Copy link
Contributor
mkralik3 commented Nov 21, 2024 •
edited
Loading

Describe the bug

Hack scripts and tests assume that istio control plane is installed in the istio-system namespace (istio-system is hardcoded on more places in the test suites). Testing OSSM2 and OSSM3 together requires 2 control planes in two different namespaces against which the Kiali tests will run. ( to have it at least in the Kiali integration test and bookinfo install script)

Add support for customization of control plane namespace to the hack script as well as tests.

(similar to #7950 but with more work to do)
Downstream issue: https://issues.redhat.com/browse/OSSM-8387
@mkralik3 mkralik3 added the enhancement This is the preferred way to describe new end-to-end features. label Nov 21, 2024
@jshaughn
Copy link
Collaborator
jshaughn commented Dec 2, 2024

@mkralik3 , which hack scripts need to be updated? And which test files? Is this something you'd like to do, otherwise it would be great to have a more specific list, thanks.

@mkralik3
Copy link
Contributor Author
mkralik3 commented Dec 2, 2024

And which test files?
The integration test suite, everywhere where istio-system is hard coded.

For the hack scripts, I haven't tried yet whether I can install bookinfo, e.g. to a different namespace (e.g. bookinfo2) and can it into the control-plane which is e.g. in istio-system-3-0 namespace.

Right now, I want to align downstream pipeline in Jenkins with upstream CI. That is why I am using ./install-testing-demos.sh -c oc -a ${params.OCP_ARCH} -gw true in downstream pipeline (not merged yet). ( since that new way (-gw true installs bookinfo with Gateway API resources and automatically creates ingress gateway in book namespace ).
The integration tests (and upstream CI) were updated by #7876. I would like to do the same for cypress tests as well.
So I postponed this issue (OSSM-8387) till that^ is done.

@jshaughn
Copy link
Colla 987B borator

@jmazzitelli , do you know if any of the relevant scripts support this already?

@mkralik3
Copy link
Contributor Author
mkralik3 commented May 6, 2025

@jshaughn
Closing this since the downstream issue was closed as Won't Do due to too much effort only for the one upgrade scenario.

@mkralik3 mkralik3 moved this from 📋 Backlog to ✅ Done in Kiali Sprint 25-08 | Kiali v2.10 May 6, 2025
@mkralik3 mkralik3 closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This is the preferred way to describe new end-to-end features.
Projects
Kiali Sprint 25-08 | Kiali v2.10
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jshaughn @mkralik3
0