8000 Code edit suggestions · Issue #10 · kegsay/github-pull-review · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Code edit suggestions #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
< 8A8C /div>
kegsay opened this issue Oct 3, 2015 · 0 comments
Open

Code edit suggestions #10

kegsay opened this issue Oct 3, 2015 · 0 comments
Labels
enhancement++

Comments

@kegsay
Copy link
Owner
kegsay commented Oct 3, 2015

You should be able to provide code suggestions when viewing up to HEAD commits. Perhaps double-clicking a line brings you into an "editor view" with a "Suggest" button? When you hit the button it will leave a commit comment with the diff hunk embedded in it to the effect of:

Suggestion:

@@ -11,1 +11,1
- var foo = "bar";
+ var foo = "beer";

When Github Pull Review sees a comment matching this form it can then pretty-display the diff hunk and add 2 buttons (YUP/NOPE) and if you hit YUP it will do the commit. Commit can be done using something like http://www.mdswanson.com/blog/2011/07/23/digging-around-the-github-api-take-2.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement++
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kegsay
0