8000 Version dependency on labelled in tests · Issue #92 · kaz-yos/tableone · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Version dependency on labelled in tests #92
New issue
New issue
Open
Open
Version dependency on labelled in tests#92
@MichaelChirico

Description

@MichaelChirico
MichaelChirico
opened on Mar 3, 2022

This line induces behavior in labelled that's not present in v1.0.0:

tableone/tests/testthat/test-CreateTableOne.R

Line 284 in b02ef39

labelled::val_label(pbc_labeled$age, 1) <- "youngest"

The issue didn't cause an error in the current CRAN version of labelled, 2.9.0. I didn't check when exactly the labelled behavior changed.

Two fixes:

  1. add skip_if_not_installed("labelled", "2.9.0") to that test
  2. add a version dependency on labelled, e.g. very conservatively labelled (>= 2.9.0)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0