8000 [Suggestion] Allow to modify module structure · Issue #575 · kaist-cp/cs420 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Suggestion] Allow to modify module structure #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Engineer-HaMa opened this issue Mar 28, 2025 · 1 comment
Open

[Suggestion] Allow to modify module structure #575

Engineer-HaMa opened this issue Mar 28, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@Engineer-HaMa
Copy link
Engineer-HaMa commented Mar 28, 2025 •
edited
Loading

I am solving #544 and encountered a problem.

The mod.rs file is getting too long, so I tried splitting it into several modules. It works well in local tests.

However, on gg.kaist.ac.kr, as stated in the notice, the test only considers the original mod.rs file.

Therefore, I suggest allowing students to freely add modules in the iregen directory. This would improve code readability and maintainability.

❯ git diff ./scripts/
diff --git a/scripts/make-submissions.sh b/scripts/make-submissions.sh
index 29ff41b8..4e52e672 100755
--- a/scripts/make-submissions.sh
+++ b/scripts/make-submissions.sh
@@ -4,7 +4,7 @@
 rm -rf irgen.zip simplify_cfg.zip mem2reg.zip gvn.zip deadcode.zip asmgen.zip final.zip

 # Creates new submissions.
-zip irgen.zip -j src/c/write_c.rs src/irgen/mod.rs
+zip irgen.zip -j src/c/write_c.rs src/irgen/*
 zip simplify_cfg.zip -j src/opt/opt_utils.rs src/opt/simplify_cfg.rs
 zip mem2reg.zip -j src/opt/opt_utils.rs src/opt/mem2reg.rs
 zip gvn.zip -j src/opt/opt_utils.rs src/opt/gvn.rs
Image
@Jaewookim08
Copy link
Collaborator

As you have noted, our grading script only copies a predefined list of files. We’re sorry, but we plan to keep this policy to ensure that important files—such as those containing unit tests—aren’t replaced by the user before running the tests.

@Lee-Janggun Lee-Janggun added the enhancement New feature or request label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jaewookim08 @Lee-Janggun @Engineer-HaMa
0