fix: return empty deployment if not found #2716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying kurtosis with
|
| Latest commit: |
c9451f9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://05fc9b53.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://tedi-dbglog.kurtosis-docs.pages.dev |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 18, 2025
🤖 I have created a release *beep* *boop* --- ## [1.7.0](1.6.0...1.7.0) (2025-04-17) ### Features * add grafloki to kurtosis config ([#2707](#2707)) ([b6794e1](b6794e1)) * export service logs (Kubenertes) ([#2693](#2693)) ([c00f357](c00f357)) * grafloki start/stop ([#2696](#2696)) ([53d823a](53d823a)) * service update ([#2689](#2689)) ([4cda391](4cda391)) ### Bug Fixes * **backend/kubernetes:** use default KUBECONFIG resolution ([#2672](#2672)) ([379e49b](379e49b)) * docker auth wasn't being used by engine and API ([#2699](#2699)) ([4eea787](4eea787)) * give grafana root access ([#2706](#2706)) ([b8e2fab](b8e2fab)) * remove k8s ingress on stop user services ([#2715](#2715)) ([e31c0d4](e31c0d4)) * return empty deployment if not found ([#2716](#2716)) ([451c70e](451c70e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restarts on grafloki start over k8s were not working because of the way the not found error was being handled. This change returns a nil object if a deployment isn't found by k8s instead of returning an error.