fix: nil docker auth test #2630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylenet
approved these changes
Jan 20, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
🤖 I have created a release *beep* *boop* --- ## [1.5.0](1.4.4...1.5.0) (2025-02-07) ### Features * Allow builtin manipulation for programmatic use ([#2642](#2642)) ([bb508ca](bb508ca)) ### Bug Fixes * nil docker auth test ([#2630](#2630)) ([ae3b2e6](ae3b2e6)) * Stdout/Stderr mixing in commands ([#2637](#2637)) ([afe0d87](afe0d87)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I kept having an issue where
TestGetAuthWithNoAuthSetReturnsNilAndNoErrorwould pull from my actual auth and thus fail because my auth settings were not nil (my auth is set at $HOME/.docker/config.json which is whereloadDockerAuth()checks ifDOCKER_CONFIGis not set). I fixed this by adjusting thewriteStaticConfigto accept an empty string, which doesn't set any auth, but does update theDOCKER_CONFIGdir to a temporary test one. This way it never uses a users actual auth directory - which could be set.Is this change user facing?
YES