8000 Implement json log format · Issue #91490 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement json log format #91490

Closed
serathius opened this issue May 27, 2020 · 2 comments · Fixed by #91608
Closed

Implement json log format #91490

serathius opened this issue May 27, 2020 · 2 comments · Fixed by #91608
Assignees
@yuzhiquan
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard.
Milestone
v1.19

Comments

@serathius
Copy link
Contributor
serathius commented May 27, 2020 •
edited
Loading

Part of kubernetes/enhancements#1602 effort

Allow users to change log out of k8s components by passing flag --log-format=json.

Details:

Suggested library to use is zap, as there is an existing implementation of logr interface https://github.com/go-logr/zapr. I expect that zapr will need some changes to comply.

/sig instrumentation
/wg component-standard
/priority important-soon
/milestone v1.19
/help
@serathius serathius added the kind/feature Categorizes issue or PR as related to a new feature. label May 27, 2020
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 27, 2020
@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 27, 2020
@serathius serathius mentioned this issue May 27, 2020
Open
39 tasks
@yuzhiquan
Copy link
Member

/assign
/remove-help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 29, 2020
@yuzhiquan yuzhiquan mentioned this issue May 31, 2020
Merged
This was referenced Jun 16, 2020
Merged
Merged
Merged
@serathius
Copy link
Contributor Author

JSON format was implemented. I created a follow up PR updating logging format flag help message #92177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzhiquan yuzhiquan

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard.
Projects
None yet
Milestone
v1.19
Development

Successfully merging a pull request may close this issue.

Feature implement json logformat yuzhiquan/kubernetes
3 participants
@yuzhiquan @serathius @k8s-ci-robot
0