-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit with Vim doesn't work on win64 #1
Comments
Did you install from the zip archive? |
@k-takata Yes, I extracted all the content in the zip archive and ran |
perhaps, we shouldn't distribute gvimext.dll and gvimext64.dll separately, but only build it once? Something like this patch: diff --git a/appveyor.bat b/appveyor.bat
index 429a27d..17c1595 100755
--- a/appveyor.bat
+++ b/appveyor.bat
@@ -199,9 +199,11 @@ goto :eof
cd vim\src
:: Build both 64- and 32-bit versions of gvimext.dll for the installer
-start /wait cmd /c "setenv /x64 && cd GvimExt && nmake clean all"
-move GvimExt\gvimext.dll GvimExt\gvimext64.dll
-start /wait cmd /c "setenv /x86 && cd GvimExt && nmake clean all"
+if /i "%ARCH%"=="x64" (
+ start /wait cmd /c "setenv /x64 && cd GvimExt && nmake clean all"
+) else (
+ start /wait cmd /c "setenv /x86 && cd GvimExt && nmake clean all"
+)
:: Create zip packages
7z a ..\..\gvim_%APPVEYOR_REPO_TAG_NAME:v=%_%ARCH%_pdb.zip *.pdb
copy /Y ..\README.txt ..\runtime |
But when we create an installer package, we must build both gvimext.dll and gvimext64.dll. Another thing we need to care about is the following item in the todo list:
Maybe we need to extend dosinst.c. |
Hm, then perhaps we need a registry file for 64bit and 32bit windows and have the installer
Isn't that what is currently done and causes this bug? |
In my understanding, the install.exe (and also the self-installer) doesn't use GvimExt.reg. GvimExt.reg can be used when a user want to register the right-click handler manually (without using install.exe).
In this case, only the 32-bit version of handler is going to be installed, but not sure the 32-bit version is installed correctly. |
FYI, there is another bug related to gvimext.dll. Maybe we need a directory structure like this:
|
Now I'm working on this at the gvimext3264 branch.
Either using self-installer or running |
32-bit version of zip package and self-installer are available at: |
Created an issue on official repository: vim/vim#2144 |
Fixed by v8.0.1191. |
Recently I updated Vim 8 and found that after I installed gVim, I can't see "Edit with Vim" in context menu.
I found the cause is now we have both
gvimext.dll
andgvimext64.dll
, but in regedit, we registered the former, which doesn't work on my win64.I ran the following registry file and now it works.
Could you help to check the system before applying the proper dll?
The text was updated successfully, but these errors were encountered: