8000 in GMime 4.0, consolidate GMimeVerifyFlags and GMimeDecryptFlags as GMimeCryptoFlags · Issue #70 · jstedfast/gmime · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

in GMime 4.0, consolidate GMimeVerifyFlags and GMimeDecryptFlags as GMimeCryptoFlags #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dkg opened this issue Dec 9, 2019 · 2 comments
Open

in GMime 4.0, consolidate GMimeVerifyFlags and GMimeDecryptFlags as GMimeCryptoFlags #70

dkg opened this issue Dec 9, 2019 · 2 comments

Comments

@dkg
Copy link
Contributor
dkg commented Dec 9, 2019

in mailing list discussion last year, i suggested consolidating GMimeVerifyFlags and GMimeDecryptFlags at the next API/ABI change.

This is just a bug report to keep track of the proposed change. (if you don't think it's a good idea, feel free to close!)
@dkg dkg mentioned this issue Dec 9, 2019
Open
@jstedfast
Copy link
Owner

Do all GMimeDecryptFlags make sense for the verify function?

Not sure why they should be consolidated.

@dkg
Copy link
Contributor Author
dkg commented Dec 10, 2019

in your message on that thread, you wrote:

What I was thinking is that we could just duplicate any VerifyFlags into DecryptFlags.

Possibly we could even make it such that bitwise-oring VerifyFlags and DecryptFlags worked.

In other words, if VerifyFlags was setup such that the enum flags did not overlap with DecryptFlags, they could be combined in the decrypt() calls.

consolidating them into a single bitfield seems simplest to me, and the documentation could just indicate if a flag has no effect on one or the other of the operations.
66FC

@jstedfast jstedfast mentioned this issue Dec 17, 2019
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkg @jstedfast
0