Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 11 commits
- 20 files changed
- 4 contributors
Commits on Aug 19, 2024
-
Temporarily comment out subtests
Due to a Node.js v22 vm issue (nodejs/node#54436), some subtests are failing that should pass, and some passing that should fail. Instead of trying to add per-subtest per-Node-version disable/enable functionality, let's just mark the whole test as failing for now, leaving the intended subtests in commented out.
Commits on Aug 24, 2024
-
Setup Window prototype in vm context
This includes a revert of commit 98c38d3. The new version works on both the latest Node versions and the older ones. This also introduces the intermediate WindowProperties object, although we don't properly put the named properties there yet.
-
This also audits the tests currently marked as flaky and updates their expectations, and raises the timeout to try to deal with Element-matches.html somehow taking longer now.
Commits on Aug 25, 2024
-
They should not set relatedTarget. And we should not fire focus/focusin on the document.
-
Refactor Window object setup code
Restructure Window.js to be less convoluted, with a single createWindow function and no fake Window constructor that operates on a this object but then manually sets is prototype chain anyway.
-
These landed upstream in web-platform-tests/wpt@c06e959.
-
-
Fix postMessage referenced as a bare property
Closes #3755. Also inlines it into Window.js since that's the general pattern for the mess of global functions we currently have.
-
-
Set EventTarget.prototype to the jsdom's Object.prototype
Previously it was set to the Node.js outer realm's Object.prototype.
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 24.1.1...25.0.0