8000 ComboBox onPillRemove listener not being called · Issue #5087 · jpmorganchase/salt-ds · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ComboBox onPillRemove listener not being called #5087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 11 tasks
tayyabataimur opened this issue May 15, 2025 · 0 comments · Fixed by #5088
Closed
2 of 11 tasks

ComboBox onPillRemove listener not being called #5087

tayyabataimur opened this issue May 15, 2025 · 0 comments · Fixed by #5088
Assignees
@tayyabataimur
Labels
community For issues that have been raised by folks outside the core Salt team component: combo box status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged.

Comments

@tayyabataimur
Copy link
Contributor

Latest version

  • I have tested the latest version

Description

In the multi-select combobox that uses Pills, when a Pill is removed, the onPillRemove callback is not triggered.

Steps to reproduce

In the following example of the ComboBox, when a pill is removed, the onPillRemove callback is not triggered.

<ComboBox
      {...{
        multiselect: true,
        value: inputValue,
        selected: values,
        valueToString: value => {
          const isTopSources = valuesHaveAllTopSources(value);

          if (isTopSources) {
            return TOP_SOURCE.label;
          } else {
            let vendor;

            if (mode === VENDOR_SPECIFIC) {
              vendor = value.slice(0, 3);
            }

            const index = values.findIndex(_value => _value === value);
            const label = labels[index];

            return [label, vendor].filter(v => v).join(' ');
          }
        },
        onPillRemove: (e, value) => {
          console.log('onPillRemove');
        },
        onChange(e) {
          onChangeInputValue(e.target.value);
        },
        onSelectionChange(e, values) {
          onChangeSelection(values);
        },
        onKeyDown(e) {
          onKeyDown(e.code);
        }
      }}
    >

Expected behavior

No response

Package name(s)

Core (@salt-ds/core)

Package version(s)

No response

Browser

  • Chrome
  • Safari
  • Firefox
  • Microsoft Edge

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@tayyabataimur tayyabataimur added status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. community For issues that have been raised by folks outside the core Salt team component: combo box labels May 15, 2025
@tayyabataimur tayyabataimur self-assigned this May 16, 2025
@tayyabataimur tayyabataimur mentioned this issue May 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tayyabataimur tayyabataimur

Labels
community For issues that have been raised by folks outside the core Salt team component: combo box status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged.
Projects
Salt - Components, Patterns and Theming
Status: Green
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trigger onPillRemove callback when a pill is removed in ComboBox jpmorganchase/salt-ds
1 participant
@tayyabataimur
0